Fix repeated failure to load DSC module #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can just be an `IEnumerable` throughout instead.
Instead of trying repeatedly every time we set a breakpoint.
The way the class properties are accessed changed.
andyleejordan
force-pushed
the
andschwa/write-output
branch
from
4381cfc to
6790594
Compare
src/PowerShellEditorServices/Services/PowerShell/Debugging/DscBreakpointCapability.cs
Outdated
Show resolved
Hide resolved
test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs
Outdated
Show resolved
Hide resolved
SeeminglyScience
approved these changes
May 8, 2023
…ions Seems to be the easiest "clean and safe" way to handle this.
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the
Write-Outputbug (hence the branch name) I came across another bug where the server was attempting to load the DSC module repeatedly. TheSetLineBreakpointlogic queries for DSC breakpoint capability, which was importing the module, catching the failure to import as an error, and then trying again every single time. Instead we should import (or fail to import) only the first time we try. Also, we don't need to transform theBreakpointDetailslist into an array and back, just leave it asIEnumerable.